-
Notifications
You must be signed in to change notification settings - Fork 8.1k
engine: consolidate network drivers documentation #23731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: David Karlsson <[email protected]>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
robmry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - comments can be suggestions for follow-up.
| 8. Clean up: | ||
|
|
||
| ```console | ||
| $ docker container stop alpine1 alpine2 | ||
| $ docker container rm alpine1 alpine2 | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add a "docker ps -a" between the stop and rm, to note that stopped containers lose their IP address etc?
| 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1 | ||
| link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 | ||
| inet 127.0.0.1/8 scope host lo | ||
| valid_lft forever preferred_lft forever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could update this to include the ::1 on lo (which will now be there unless IPv6 is disabled on the host, or by sysctl-ing the container).
aevesdocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Picky style guide nits. Otherwise LGTM
| ## Usage example | ||
|
|
||
| This example shows how to start an nginx container that binds directly to port | ||
| 80 on the Docker host. From a networking perspective, this provides the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 80 on the Docker host. From a networking perspective, this provides the same | |
| `80` on the Docker host. From a networking perspective, this provides the same |
|
|
||
| ## Usage example | ||
|
|
||
| This example shows how to start an nginx container that binds directly to port |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This example shows how to start an nginx container that binds directly to port | |
| This example shows how to start an Nginx container that binds directly to port |
|
|
||
| This example shows how to start an nginx container that binds directly to port | ||
| 80 on the Docker host. From a networking perspective, this provides the same | ||
| level of isolation as if nginx were running directly on the host, but the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| level of isolation as if nginx were running directly on the host, but the | |
| level of isolation as if Nginx were running directly on the host, but the |
|
|
||
| ### Prerequisites | ||
|
|
||
| - Port 80 must be available on the Docker host. To make nginx listen on a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Port 80 must be available on the Docker host. To make nginx listen on a | |
| - Port `80` must be available on the Docker host. To make Nginx listen on a |
| ### Prerequisites | ||
|
|
||
| - Port 80 must be available on the Docker host. To make nginx listen on a | ||
| different port, see the [nginx image documentation](https://hub.docker.com/_/nginx/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| different port, see the [nginx image documentation](https://hub.docker.com/_/nginx/). | |
| different port, see the [Nginx image documentation](https://hub.docker.com/_/nginx/). |
| nginx | ||
| ``` | ||
|
|
||
| The default `ingress` publish mode means you can browse to port 80 on any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The default `ingress` publish mode means you can browse to port 80 on any | |
| The default `ingress` publish mode means you can browse to port `80` on any |
| $ docker network create -d overlay my-overlay | ||
| ``` | ||
|
|
||
| 2. Start a service using the overlay network, publishing port 80 to port 8080: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 2. Start a service using the overlay network, publishing port 80 to port 8080: | |
| 2. Start a service using the overlay network, publishing port `80` to port `8080`: |
| You need two Docker hosts that can communicate with each other with the | ||
| following ports open between them: | ||
|
|
||
| - TCP port 2377 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - TCP port 2377 | |
| - TCP port `2377` |
| following ports open between them: | ||
|
|
||
| - TCP port 2377 | ||
| - TCP and UDP port 7946 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - TCP and UDP port 7946 | |
| - TCP and UDP port `7946` |
|
|
||
| - TCP port 2377 | ||
| - TCP and UDP port 7946 | ||
| - UDP port 4789 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - UDP port 4789 | |
| - UDP port `4789` |
Description
Conslidates the documentation on network drivers, which for some drivers is
currently split up into two separate pages:
This PR removes the separate tutorials page and incorporates the relevant
content into the main page.